-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update citations.md #1384
Update citations.md #1384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, can't imagine what would break but merge once CI is happy 👍
CI is failing on type checking. We don't pin
Suggestion: Change the above (here https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L48) to:
and open an issue to fix/modify at a later date (perhaps it's time for a |
It's an unrelated type hint issue due to numpy 1.2.0.
|
I've opened #1385 that fixes the issues for me locally. |
This fixes the two errors: ``` axelrod/fingerprint.py:444: error: Function "numpy.array" is not valid as a type 22 axelrod/fingerprint.py:444: note: Perhaps you need "Callable[...]" or a callback protocol? 23 Found 1 error in 1 file (checked 1 source file) ``` and: ``` axelrod/strategies/ann.py:125: error: Incompatible types in assignment (expression has type "ndarray", variable has type "List[int]") 34 Found 1 error in 1 file (checked 1 source file) ``` note that in `fingerprint.py` I'm using the `ArrayType` type but that when I tried to use that in `ann.py` a lot of other things broke.
Note we can also remove it from the docs.
No longer necessary.
No description provided.